Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][test] Fix ManagedCursorTest.testForceCursorRecovery #23518

Merged
merged 6 commits into from
Nov 5, 2024
+2 −2
Merged

[fix][test] Fix ManagedCursorTest.testForceCursorRecovery #23518

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4371f0
issue #23417 Flaky-test
ZhaoGuorui666 Oct 27, 2024
f3c433e
issue #23417 Flaky-test
ZhaoGuorui666 Oct 27, 2024
1adf50b
issue #23417 Flaky-test - add return
ZhaoGuorui666 Oct 30, 2024
d2ff10e
issue #23417 Flaky-test
ZhaoGuorui666 Oct 30, 2024
8425f47
Merge branch 'apache:master' into testForceCursorRecovery
ZhaoGuorui666 Nov 3, 2024
3dd817f
solve issue#23417
ZhaoGuorui666 Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4828,7 +4828,6 @@ public void operationFailed(ManagedLedgerException exception) {

@Test
void testForceCursorRecovery() throws Exception {
ManagedLedgerFactoryConfig managedLedgerFactoryConfig = new ManagedLedgerFactoryConfig();
TestPulsarMockBookKeeper bk = new TestPulsarMockBookKeeper(executor);
factory = new ManagedLedgerFactoryImpl(metadataStore, bk);
ManagedLedgerConfig config = new ManagedLedgerConfig();
Expand Down Expand Up @@ -4874,8 +4873,9 @@ public void asyncOpenLedger(final long lId, final DigestType digestType, final b
final OpenCallback cb, final Object ctx) {
if (ledgerErrors.containsKey(lId)) {
cb.openComplete(ledgerErrors.get(lId), null, ctx);
} else {
super.asyncOpenLedger(lId, digestType, passwd, cb, ctx);
}
super.asyncOpenLedger(lId, digestType, passwd, cb, ctx);
}
}

Expand Down
Loading