Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix print cluster migration state response #23535

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Oct 31, 2024

PIP: #16551

Motivation

Currently, pulsar-admin cli is not printing cluster migration state response and this PR fixes the printing it on console.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia added area/broker doc-not-needed Your PR changes do not impact docs ready-to-test labels Oct 31, 2024
@rdhabalia rdhabalia added this to the 4.1.0 milestone Oct 31, 2024
@rdhabalia rdhabalia self-assigned this Oct 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.32%. Comparing base (bbc6224) to head (94b491a).
Report is 707 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23535      +/-   ##
============================================
+ Coverage     73.57%   74.32%   +0.74%     
- Complexity    32624    34424    +1800     
============================================
  Files          1877     1943      +66     
  Lines        139502   147045    +7543     
  Branches      15299    16205     +906     
============================================
+ Hits         102638   109285    +6647     
- Misses        28908    29322     +414     
- Partials       7956     8438     +482     
Flag Coverage Δ
inttests 27.42% <0.00%> (+2.84%) ⬆️
systests 24.37% <0.00%> (+0.04%) ⬆️
unittests 73.71% <100.00%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../java/org/apache/pulsar/admin/cli/CmdClusters.java 71.91% <100.00%> (-2.94%) ⬇️

... and 653 files with indirect coverage changes

@lhotari lhotari merged commit 76d0e6c into apache:master Nov 1, 2024
56 of 59 checks passed
@rdhabalia rdhabalia deleted the blue_cli branch November 1, 2024 23:39
visxu pushed a commit to vissxu/pulsar that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants