Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Disable OTel autoconfigured exporters in tests #23540

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Nov 1, 2024

Motivation

Running InflightReadsLimiterTest is slow and prints these warnings

Nov 01, 2024 4:37:19 PM io.opentelemetry.sdk.internal.ThrottlingLogger doLog
WARNING: Failed to export metrics. Server responded with gRPC status code 2. Error message: Failed to connect to localhost/[0:0:0:0:0:0:0:1]:4317
Nov 01, 2024 4:37:21 PM io.opentelemetry.sdk.internal.ThrottlingLogger doLog
WARNING: Failed to export metrics. Server responded with gRPC status code 2. Error message: Failed to connect to localhost/[0:0:0:0:0:0:0:1]:4317
Nov 01, 2024 4:37:26 PM io.opentelemetry.sdk.internal.ThrottlingLogger doLog
WARNING: Failed to export metrics. Server responded with gRPC status code 2. Error message: Failed to connect to localhost/[0:0:0:0:0:0:0:1]:4317
Nov 01, 2024 4:37:31 PM io.opentelemetry.sdk.internal.ThrottlingLogger doLog
WARNING: Failed to export metrics. Server responded with gRPC status code 2. Error message: Failed to connect to localhost/[0:0:0:0:0:0:0:1]:4317

Default OTel exporters should be disabled in tests by default.

Modifications

Disable default OTel exporters in tests.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari
Copy link
Member Author

lhotari commented Nov 1, 2024

@dragosvictor @heesung-sn Please review

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 1, 2024
@heesung-sn
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (bbc6224) to head (f902ce2).
Report is 707 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23540      +/-   ##
============================================
+ Coverage     73.57%   74.29%   +0.72%     
- Complexity    32624    34402    +1778     
============================================
  Files          1877     1943      +66     
  Lines        139502   147050    +7548     
  Branches      15299    16209     +910     
============================================
+ Hits         102638   109256    +6618     
- Misses        28908    29355     +447     
- Partials       7956     8439     +483     
Flag Coverage Δ
inttests 27.59% <ø> (+3.01%) ⬆️
systests 24.37% <ø> (+0.04%) ⬆️
unittests 73.67% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 656 files with indirect coverage changes

@lhotari lhotari merged commit 570cb44 into apache:master Nov 2, 2024
54 of 55 checks passed
visxu pushed a commit to vissxu/pulsar that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants