Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] fix logging with correct error message while loading the topic #23544

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Nov 1, 2024

Motivation

Currently when broker fails to load topic it always logs error message with config failure but logging should be done based on exception type to help user while debugging the issue. So, fix the logging during topic loading.

Modifications

Fix the logging message.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.33%. Comparing base (bbc6224) to head (c9d66a1).
Report is 710 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23544      +/-   ##
============================================
+ Coverage     73.57%   74.33%   +0.76%     
- Complexity    32624    34424    +1800     
============================================
  Files          1877     1943      +66     
  Lines        139502   147053    +7551     
  Branches      15299    16210     +911     
============================================
+ Hits         102638   109318    +6680     
- Misses        28908    29295     +387     
- Partials       7956     8440     +484     
Flag Coverage Δ
inttests 27.58% <0.00%> (+2.99%) ⬆️
systests 24.40% <0.00%> (+0.08%) ⬆️
unittests 73.71% <100.00%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rg/apache/pulsar/broker/service/BrokerService.java 83.99% <100.00%> (+3.21%) ⬆️

... and 656 files with indirect coverage changes

@lhotari lhotari merged commit ce0c1bb into apache:master Nov 5, 2024
56 of 59 checks passed
visxu pushed a commit to vissxu/pulsar that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants