-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [admin] Fix lookup get a null result if uses proxy #23556
Merged
poorbarcode
merged 1 commit into
apache:master
from
poorbarcode:fix/lookup_get_null_result
Nov 5, 2024
Merged
[fix] [admin] Fix lookup get a null result if uses proxy #23556
poorbarcode
merged 1 commit into
apache:master
from
poorbarcode:fix/lookup_get_null_result
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
requested review from
lhotari,
Technoboy-,
codelipenghui and
shibd
November 4, 2024 12:09
shibd
approved these changes
Nov 5, 2024
Technoboy-
approved these changes
Nov 5, 2024
hanmz
approved these changes
Nov 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23556 +/- ##
============================================
+ Coverage 73.57% 74.31% +0.74%
- Complexity 32624 34424 +1800
============================================
Files 1877 1943 +66
Lines 139502 147051 +7549
Branches 15299 16209 +910
============================================
+ Hits 102638 109288 +6650
- Misses 28908 29330 +422
- Partials 7956 8433 +477
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
added a commit
that referenced
this pull request
Nov 5, 2024
(cherry picked from commit c53a85e)
poorbarcode
added a commit
that referenced
this pull request
Nov 5, 2024
(cherry picked from commit c53a85e)
poorbarcode
added a commit
that referenced
this pull request
Nov 5, 2024
(cherry picked from commit c53a85e)
visxu
pushed a commit
to vissxu/pulsar
that referenced
this pull request
Nov 6, 2024
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Nov 6, 2024
(cherry picked from commit c53a85e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.8
release/3.3.3
release/4.0.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the user deploys a cluster with proxy, and network topology like this: Client -> Proxy(with TLS) -> Broker(without TLS)
When the user calls
pulsar-admin topics lookup <topic name>
, the user will get anull
response.But the exact value that the broker responded to is below:
It is caused by the pulsar-admin client's issue: https://github.com/apache/pulsar/blob/master/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/LookupImpl.java#L60
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x