Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis Build - install xmllint and enforce backward compatibility with gcc4.4 #242

Merged
merged 1 commit into from
Feb 24, 2017
Merged

Travis Build - install xmllint and enforce backward compatibility with gcc4.4 #242

merged 1 commit into from
Feb 24, 2017

Conversation

jai1
Copy link
Contributor

@jai1 jai1 commented Feb 24, 2017

Motivation

a. Fix C++ build - Need to install xmllint in, Travis default build env ( Ubuntu 14.04 ).
b. enforce backward compatibility with gcc4.4

Modifications

Added a print message in CMakeList.txt
Added libxml2 and gcc4.4 to travis_build.sh

Result

C++ compilation should succeed in master

@jai1 jai1 added type/bug The PR fixed a bug or issue reported a bug c++ labels Feb 24, 2017
@jai1 jai1 added this to the 1.17 milestone Feb 24, 2017
@jai1 jai1 self-assigned this Feb 24, 2017
@saandrews
Copy link
Contributor

👍

merlimat
merlimat approved these changes Feb 24, 2017
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, though please explain a bit more about the change in the git log message

@merlimat merlimat changed the title C++ - Fix travis Travis Build - install xmllint and enforce backward compatibility with gcc4.4 Feb 24, 2017
@merlimat merlimat removed the type/bug The PR fixed a bug or issue reported a bug label Feb 24, 2017
@merlimat merlimat merged commit 5dcb440 into apache:master Feb 24, 2017
@jai1 jai1 deleted the FixTravis2 branch March 6, 2017 17:43
sijie added a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
@sijie
Move all the components required for running worker (except rest end…
914179c 
…point) to WorkerService (apache#242)

* Move all the components required for running worker (except rest endpoint) to WorkerService (apache#239)

* start worker service
sijie pushed a commit that referenced this pull request Jun 30, 2019
@rdhabalia @sijie
[pulsar-broker] fix deadlock on get-status rest-api call (#4616)
f272df9 
### Motivation

due to some issue if broker fails to complete topic-loading then getting stats of that topic blocks web-thread.

```
"pulsar-web-30-13" #242 prio=5 os_prio=0 tid=0x00002b0b3c001000 nid=0x2540 waiting on condition [0x00002b0aa7d0a000]
   java.lang.Thread.State: WAITING (parking)
        at sun.misc.Unsafe.park(Native Method)
        - parking to wait for  <0x000000072560a180> (a java.util.concurrent.CompletableFuture$Signaller)
        at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
        at java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1693)
        at java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3323)
        at java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1729)
        at java.util.concurrent.CompletableFuture.join(CompletableFuture.java:1934)
        at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.getTopicReference(PersistentTopicsBase.java:1253)
        at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.internalGetStats(PersistentTopicsBase.java:592)
        at org.apache.pulsar.broker.admin.v1.PersistentTopics.getStats(PersistentTopics.java:240)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
```
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
@rdhabalia @jiazhai
[pulsar-broker] fix deadlock on get-status rest-api call (#4616)
71b6e92 
### Motivation

due to some issue if broker fails to complete topic-loading then getting stats of that topic blocks web-thread.

```
"pulsar-web-30-13" #242 prio=5 os_prio=0 tid=0x00002b0b3c001000 nid=0x2540 waiting on condition [0x00002b0aa7d0a000]
   java.lang.Thread.State: WAITING (parking)
        at sun.misc.Unsafe.park(Native Method)
        - parking to wait for  <0x000000072560a180> (a java.util.concurrent.CompletableFuture$Signaller)
        at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
        at java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1693)
        at java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3323)
        at java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1729)
        at java.util.concurrent.CompletableFuture.join(CompletableFuture.java:1934)
        at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.getTopicReference(PersistentTopicsBase.java:1253)
        at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.internalGetStats(PersistentTopicsBase.java:592)
        at org.apache.pulsar.broker.admin.v1.PersistentTopics.getStats(PersistentTopics.java:240)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
```
(cherry picked from commit f272df9)
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
@BewareMyPower
Set controller to broker itself when metadata request is processed (a…
6322ecf 
…pache#242)

KoP needs no controller id because it's used for metadata operations in Kafka. So it simply sets controller id field to -1 when metadata request is processed.

However, before a Kafka's AdminClient send a metadata related request like CreateTopics, it sent a metadata request and try to get a valid controller broker from the controller id field of metadata response. If the controller id is invalid, the AdminClient will send metadata request infinitely.

Since each broker can manage metadata, this PR change metadata response's controller id to the self node's controller id, which is generated by a hash function.

In addition, this PR adds a test to verify Kafka's AdminClient won't stuck at the CreateTopics method which is not supported currently.
@xiaotongwang1 xiaotongwang1 mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@jai1 jai1

Labels
None yet
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.
3 participants
@jai1 @saandrews @merlimat