Corrected test case #243
Merged
Corrected test case #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix looks good, though can you mention which test has been corrected in the git log message? 😄 |
jai1
force-pushed
the
FixProxyPublishConsumeTest
branch
from
6471f6f to
52272e5
Compare
|
@merlimat - added the name of the test case in the commit message. |
merlimat
approved these changes
Feb 24, 2017
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
- pass `WorkerService` instance around in servlet context - rename `BaseApiResource` to `FunctionApiResource` - rename `ApiV1Resource` to `FunctionApiV1Resource`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Possible fix for #237
Can't replicate the timeout error but have seen the test case fail if the port is used by some other process
Modifications
Removed hardcoding for port 6080 and used the next free available port
Result
Hopefully the intermittent test case failures will reduce.