Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in ConsumerBase.java to return failed future - #249 #257

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Fix in ConsumerBase.java to return failed future - #249 #257

merged 1 commit into from
Mar 1, 2017

Conversation

jai1
Copy link
Contributor

@jai1 jai1 commented Mar 1, 2017

Motivation

Fix for Issue #249

Modifications

Added return statements

Result

Failed futures will be returned if the consumer is not ready

@jai1 jai1 mentioned this pull request Mar 1, 2017
Closed
merlimat
merlimat reviewed Mar 1, 2017
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, can you also add a quick unit test to verify these results?

@jai1 jai1 force-pushed the FixForIssue249 branch from fbbc54d to 219bbb4 Compare March 1, 2017 20:43
@jai1 jai1 force-pushed the FixForIssue249 branch from 219bbb4 to 71dcfb1 Compare March 1, 2017 20:44
@jai1
Copy link
Contributor Author

jai1 commented Mar 1, 2017

Added tests - can i get a +1 please

merlimat
merlimat approved these changes Mar 1, 2017
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label Mar 1, 2017
@merlimat merlimat added this to the 1.17 milestone Mar 1, 2017
@merlimat merlimat merged commit 24c7724 into apache:master Mar 1, 2017
@jai1 jai1 deleted the FixForIssue249 branch March 6, 2017 17:42
sijie added a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
@sijie
Use distributedlog-core-shaded in pulsar worker (apache#257)
981e472
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
@jonyhy96
feat: support limit the retry number of reconnectToBroker (apache#360)
44b8b4e 
Signed-off-by: jonyhy96 <hy352144278@gmail.com>

Fixes apache#257

### Motivation

Once the connection is closed the reconnectToBroker logic of both producer and consumer will try to reconnect to the broker infinatly.

### Modifications

Add a field in the Options represent the max number of retries and not break current behavior if this field is not fullfilled.
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
@dockerzhang
add kop address cache to prevent query zk each time (apache#257)
752bfa1 
improvement for [apache#256](streamnative/kop#256)
@xiaotongwang1 xiaotongwang1 mentioned this pull request Aug 4, 2021
Closed
eolivelli added a commit to eolivelli/pulsar that referenced this pull request May 14, 2024
@eolivelli
[improve][storage] Periodically rollover Cursor ledgers (apache#257)
75b2db9
eolivelli added a commit to eolivelli/pulsar that referenced this pull request May 14, 2024
@eolivelli @nicoloboschi
[improve][storage] Periodically rollover Cursor ledgers (apache#257)
5d73f6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@jai1 jai1

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.
2 participants
@jai1 @merlimat