Replaced use of System.out.println() in unit tests #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
approved these changes
Mar 1, 2017
jai1
reviewed
Mar 1, 2017
| @@ -26,7 +26,6 @@ | |||
| @Test | |||
| public void shouldBackoffTest() { | |||
| long currentTimestamp = System.nanoTime(); | |||
| System.out.println(currentTimestamp); | |||
There was a problem hiding this comment.
intentionally wanted to delete it ?
There was a problem hiding this comment.
Yes, printing the timestamp is kind of irrelevant in that test
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Co-authored-by: yexijun <yexijun@cmcm.com>
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use logger to print debug in unit tests so that it can be turned on/off.