Added g++-4.4 to travis build #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Mar 1, 2017
pulsar-client-cpp/CMakeLists.txt
Outdated
| @@ -64,7 +62,8 @@ set(CLIENT_LIBS | |||
| pulsar | |||
| ) | |||
|
|
|||
| message( STATUS "GCC_DUMP_VERSION: " ${GCC_DUMP_VERSION} ) | |||
| message( STATUS "CMAKE_C_COMPILER: " ${CMAKE_C_COMPILER} ) | |||
There was a problem hiding this comment.
Cmake is already printing the gcc / g++ versions. It prints it only the first time when it does the configuration phase.
If you remove, CMakeCache and do cmake . again, you'll see it printed
There was a problem hiding this comment.
@merlimat - saw it, thanks :-)
jai1
force-pushed
the
CPPBackwardCompatibility
branch
from
5cedc33
to
fa8c9f0
Compare
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* Move the thread construction to start to avoid illegalstate * Add more checks to see if thread var is init
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
fixes apache#266 `topics` in `KafkaTopicManager` will cache `PersistentTopic` by `brokerService.getTopic`, it's unnecessary because `PersistentTopic` is cached in `brokerService.getTopic`. we should remove it to avoid getting a `null` topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Want to compile cpp client using gcc and g++ 4.4 - Fix for #262
Modifications
messages added to cmake file
travis build modified to use gcc and g++ 4.4
Result
C++ client compiled using gcc and g++ 4.4
Fixes #262