amend some typographic errors in docs/Architecture.md and docs/Authen… #30
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
…JavaInstance (apache#30) ### Motivation SerDe is user defined class which used for serializing and deserializing objects for functions. So the initialization of a SerDe class should happen along with Function class and done by the context class loader. Also SerDe should be a generic-typed interface and the type should be consistent with function type. ### Modifications - make SerDe a generic-typed interface - move SerDe initialization to JavaInstance and use the thread context class loader - verify SerDe type - move reflection related code to a util class `Reflections` ### Result - SerDe is a generic-typed interface - JavaInstance initializes both function and serdes and verifies the types.
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
Change Interface to same as java / cpp client.
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
* Complete implememtation of group coordinator * Complete the implementation of GroupCoordinator * Implement group coordinator service * Handle group coordinator requests *Motivation* We already implement Kafka group coordinator. This change wires the group coordinator requests with the Kafka group coordinator.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There were some typographic errors in documents.
Modifications
I amended following typographic errors.
Result