In unit tests, do ZK cache reloads in same thread, to avoid race conditions #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
### Motivation input type can be different output type. so we need two serdes for each function. ### Modifications - add inputSerde and outputSerde - verify both input and output serde to make sure their types are consistent with function types ### Result user run functions with input/output serdes.
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
Implement Reader
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There a are several intermittent failures in unit test under Travis CI docker container. Some of them are due to ZK cache updating in background.
Modifications
Use same thread executor for mocked service to update cache immediately.
Result
Few of the intermittent unit tests failures should be resolved. eg: #12