Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After #3228, removed usages of deprecated client API #3272

Merged
merged 12 commits into from
Jan 5, 2019
Merged

After #3228, removed usages of deprecated client API #3272

merged 12 commits into from
Jan 5, 2019

Conversation

merlimat
Copy link
Contributor

Motivation

  • Refactored tests and other parts to only use the non deprecated methods.
  • Removed the interfaces that were already copied in pulsar-client-1x module

@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Dec 31, 2018
@merlimat merlimat added this to the 2.3.0 milestone Dec 31, 2018
@merlimat merlimat self-assigned this Dec 31, 2018
@merlimat
Copy link
Contributor Author

merlimat commented Jan 1, 2019

(Removed ProducerConfiguration from flink streaming connector API. Since it was not yet release, there is no API compatibility issue).

@merlimat
Copy link
Contributor Author

merlimat commented Jan 2, 2019

run integration tests

@jai1
Copy link
Contributor

jai1 commented Jan 4, 2019

rerun java8 tests

@jai1
Copy link
Contributor

jai1 commented Jan 4, 2019

run integration tests

@merlimat
Copy link
Contributor Author

merlimat commented Jan 4, 2019

run integration tests

@merlimat merlimat force-pushed the separate-api-from-impl branch 2 times, most recently from fc5adef to 2841483 Compare January 5, 2019 00:52
@merlimat
Copy link
Contributor Author

merlimat commented Jan 5, 2019

run integration tests

@merlimat merlimat force-pushed the separate-api-from-impl branch from 2841483 to 34391c9 Compare January 5, 2019 16:55
@merlimat merlimat merged commit 4a85bb7 into apache:master Jan 5, 2019
@merlimat merlimat deleted the separate-api-from-impl branch January 6, 2019 03:05
@merlimat merlimat restored the separate-api-from-impl branch January 6, 2019 18:20
hapihu added a commit to hapihu/pulsar that referenced this pull request Jun 5, 2019
@hapihu
Update concepts-messaging.md
464766b 
Since the  apache#1089，the interface 'org.apache.pulsar.client.api.PulsarClient' has supported builder for consumer and producer.
And,int the apache#3272, some deprecated client API have been removed including 'public static PulsarClient create(String serviceUrl)','Consumer<byte[]> subscribe(String topic, String subscription)' and 'Producer<byte[]> createProducer(String topic)'.

So, I modified the example with the current version of the interface.
@hapihu hapihu mentioned this pull request Jun 5, 2019
Merged
merlimat added a commit that referenced this pull request Jun 6, 2019
@hapihu @merlimat
Update concepts-messaging.md (#4483)
304843f 
* Update concepts-messaging.md

Since the  #1089，the interface 'org.apache.pulsar.client.api.PulsarClient' has supported builder for consumer and producer.
And,int the #3272, some deprecated client API have been removed including 'public static PulsarClient create(String serviceUrl)','Consumer<byte[]> subscribe(String topic, String subscription)' and 'Producer<byte[]> createProducer(String topic)'.

So, I modified the example with the current version of the interface.

* Apply suggestions from code review

Specify message schema

Co-Authored-By: Matteo Merli <mmerli@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jai1 jai1 jai1 approved these changes

@jerrypeng jerrypeng jerrypeng approved these changes

@ivankelly ivankelly Awaiting requested review from ivankelly

@sijie sijie Awaiting requested review from sijie

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@nkurihar nkurihar Awaiting requested review from nkurihar

Assignees

@merlimat merlimat

Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@merlimat @jai1 @jerrypeng