return if serviceNotReady while creating topic #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saandrews
approved these changes
Apr 6, 2017
merlimat
approved these changes
Apr 6, 2017
rdhabalia
added a commit
that referenced
this pull request
Apr 7, 2017
This was referenced Apr 12, 2017
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Fixes apache#336 Besides applying the LightProto generated new package name and some new APIs, this PR also fixes the tests error caused by apache#9240, which introduces a new method PulsarService#createLocalMetadataStore. And some tests are affected by the wrong parse of entry data after the pulsar update, this PR fixes the test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
while creating topic : completes future with exception and return if bundle is not ready.
Modifications
return with failed result future if bundle is disable.
Result
It will avoid topic creation if bundle is disable.