register listener on dynamic-config zpath even if deserialization fail on service startup #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l on service startup
saandrews
approved these changes
Apr 12, 2017
merlimat
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If user creates/updates dynamic-config znode with invalid json-map then deserialization fails and broker-service doesn't set the watch-listener on the znode so, updating znode again with the correct data will not trigger the listener and broker will not be able to update the configuration.
Modifications
Register dynamic-config listener regardless deserialization of dynamic-config json map.
Result
Broker service can set watch-listener even if dynamic-config json is invalid and failed to deserialize it.