Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly calling out the need to close the client in both the produ… #4

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Conversation

JGailor
Copy link
Contributor

@JGailor JGailor commented Sep 8, 2016

Motivation

I'm making this change for clarification in the Getting Started guide which is the gateway for new users to Pulsar.

Modifications

Updated documentation.

Result

Just the documentation.

@yahoocla
Copy link

yahoocla commented Sep 8, 2016

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@yahoocla
Copy link

yahoocla commented Sep 8, 2016

CLA is valid!

@merlimat
Copy link
Contributor

merlimat commented Sep 8, 2016

👍 Thanks for submitting the fix!

@merlimat merlimat merged commit d913f71 into apache:master Sep 8, 2016
sijie referenced this pull request in sijie/pulsar Mar 4, 2018
- introduce a `fs` package for function state related classes
- add `FunctionConfig` for user defined function configurations
- add `CmdFunctions`: it takes a yaml file and also command parameters
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
hangc0276 referenced this pull request in hangc0276/pulsar May 26, 2021
Master Issue: #4 

This is the request produce  implementation.
Basic logic:
- For passed in PartitionTopic, create related Pulsar persistent topic.
- For passed in Kafka Records, write data to related pulsar persistent topic.
hangc0276 referenced this pull request in hangc0276/pulsar May 26, 2021
Master Issue: #4 

This is the request Fetch implementation.
Basic logic: For each Fetch request from a partition, create and maintain a NonDurableCursor to read from backed PersistentTopic.

** changes **
- Add basic code implementation
- Add unit tests.
hangc0276 referenced this pull request in hangc0276/pulsar May 26, 2021
Master Issue: #4 

*Motivation*

Support Kafka group coordinator protocols.
hangc0276 referenced this pull request in hangc0276/pulsar May 26, 2021
Master Issue: #4 

*Motivation*

Support storing and committing offsets in group metadata manager.
dlg99 referenced this pull request in dlg99/pulsar Jul 20, 2021
… Downgrading debezium to the same version as apache. (#4)
@zhcn zhcn mentioned this pull request Aug 25, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants