Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed default maxPendingMessages to 30000 #445

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Changed default maxPendingMessages to 30000 #445

merged 1 commit into from
Jun 2, 2017

Conversation

jai1
Copy link
Contributor

@jai1 jai1 commented Jun 1, 2017

Motivation

Fix for #422

Modifications

Changed default options in CPP and Java Client ProducerConfigurations

Result

sendAsync doesn't fail before 30K messages

Do not merge this

@jai1 jai1 added c++ type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Jun 1, 2017
@jai1 jai1 added this to the 1.18 milestone Jun 1, 2017
@jai1 jai1 self-assigned this Jun 1, 2017
@jai1 jai1 mentioned this pull request Jun 1, 2017
Merged
merlimat
merlimat approved these changes Jun 2, 2017
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jai1 jai1 merged commit d990b17 into apache:master Jun 2, 2017
@jai1 jai1 deleted the maxPendingMessage branch March 19, 2018 17:28
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
@josephglanville
Create cluster if it doesn't exist during metadata initialisation (ap…
5ee6bf0 
…ache#445)

This case is usually encountered when attempting to use KoP with standalone mode. When new behavior was introduced in apache#168 standalone mode was broken due to sample namespace setup etc not taking place until after the broker is initialized (which in turn initializes protocol handlers).

Fixes apache#185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@msb-at-yahoo msb-at-yahoo Awaiting requested review from msb-at-yahoo

@saandrews saandrews Awaiting requested review from saandrews

Assignees

@jai1 jai1

Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
2 participants
@jai1 @merlimat