synchronized should be used for final map consumers other than method parameter consumer. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synchronized should be used for final map 'consumers' other than method parameter 'consumer'.
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
henng
changed the title
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* Refactor to support at-least-once processing This change is refactoring the relationship between Spawner, FunctionContainer and JavaInstance to better support various processing semantics. - ThreadFunctionContainerFactory is a "singleton" across multiple functions. - Spawner, FunctionContainer and JavaInstance are per function. Spawner is manging the lifecycle of function container, in the function container it will folks a thread for running java instance, because it has to load classpathes correctly. - Remove subscribermanager and move consumer and producer logic into container. that means in future if we are supporting process based and docker based container, we can just take the thread container and run it directly as a separate process or a separate docker process. There is no extra communication between spawner and containers. * Create pulsar client in thread container factory
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
* [Issue:53]Fix concurrent map write Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Tries to Provided a Tenant name in tests to make the tests more clear.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
synchronized should be used for final map
consumersother than method parameterconsumer.Modifications
Result
synchronizedworks correctly.