At closing consumer: make pendingRead false when no consumer is connected to SingleDispatcher #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted to SingleDispatcher
|
CLA is valid! |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* Added atmost once and atleast once semantics * Added ability to specify processing guarantees in command line
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
In RequestHandler, we use `PersistentTopicsBase.getPartitionedTopicMetadata` to get topic metadata. This need to passed in `authRole`. While with pulsar auth disable, or KoP SASL auth enable, both will work OK. But with pulsar auth enabled, and KoP SASL auth disable, it may meet problem. This change changed to use `admin.topics().getPartitionedTopicMetadataAsync` to get metadata. By this way, the pulsar auth is still enable in the internal pulsar-admin/pulsar-client, and will not affect KoP.
cbornet
pushed a commit
to cbornet/pulsar
that referenced
this pull request
Apr 5, 2022
(cherry picked from commit 09ec366)
nicoloboschi
referenced
this pull request
in nicoloboschi/pulsar
Apr 12, 2022
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 11, 2022
(cherry picked from commit 09ec366)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In case of
Exclusiveconsumer is disconnecting and if it doesn't fliphavePendingRead=falseat PersistentDispatcherSingleActiveConsumer, then on next reconnection consumer will not receive new messages and it will be blocked.So, we should make
havePendingRead=falseat the time of disconnect-consumer if there is no consumer availableExclusivesubscription: ifhavePendingRead=trueandcursor.cancelPendingReadRequest()=false (which will be the case if there is no pendingReadOp present at ManagedCursor),havePendingReadwill be always true and next time when new consumer will connect, it might get blocked at pickAndScheduleActiveConsumer while addConsumer() and at consumerFlowModifications
Always clear pendingRead at Exclusive consumer disconnect.
Result
Avoid possibility of exclusive consumer blocking.