Use threadsafe formatter #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2016 15:28
|
CLA is valid! |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
- add assert check Fixes apache#64 Change-Id: Ibd355440ccf3b06ac60575a9306cfb66cb80d759
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
--- Fixes apache#64 *Motivation* Currently, kop protocol handler only prints header at debug statements. We also need request and response. *Modifications* - Add more request and response info
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure thread safety.
This will fix #62. findbugs suggests the same thing too.
I'm not sure whether it is causing bad things but it can be a problem.
Modifications
Replace the date formatters with DateTimeFormatter class.
Result
Be thread safe.