Reduce Dispatcher-totalPermits by number of messages delivered in batch #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
2 similar comments
|
CLA is valid! |
|
CLA is valid! |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Change-Id: I9d5d544808a6f739d79776a4f154d7caceaa133c remove extra timeout param on UnackedMessageTracker#handlerCmd
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
This PR is adding: * integrations tests for KoP with testcontainers, * librdkafka support by allowing ListOffsets in v0 # Produce and Consume support ## Golang * [https://github.com/Shopify/sarama](https://github.com/Shopify/sarama) * [https://github.com/confluentinc/confluent-kafka-go](https://github.com/confluentinc/confluent-kafka-go) ## Rust * [https://github.com/fede1024/rust-rdkafka](https://github.com/fede1024/rust-rdkafka) ## NodeJS * [https://github.com/Blizzard/node-rdkafka](https://github.com/Blizzard/node-rdkafka) # Partial support ### [kafka-node](https://www.npmjs.com/package/kafka-node) Producing is working, but consuming is failing as the library is sending FETCH v0 regardless of API_VERSIONS responses: ``` DEBUG io.streamnative.kop.KafkaCommandDecoder - Write kafka cmd response back to client. request: RequestHeader(apiKey=FETCH, apiVersion=0, clientId=kafka-node-client, correlationId=4) INFO io.streamnative.kop.KafkaIntegrationTest - STDOUT: Error: Not a message set. Magic byte is 2 ```
cbornet
pushed a commit
to cbornet/pulsar
that referenced
this pull request
Apr 11, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dispatcher.totalPermits and Consumer.messagePermits count must be consistent else it may block client-consumer while fetching messages. Right now, it is inconsistent in case of Batch-message with shared-subscription consumer usecase.
Modifications
Maintain permits-counter in Dispatcher and Consumer by reducing total number of messages sent in a given batch-message rather just considering 1 message per batch-message in Dispatcher.
Result
It will maintain Dispatcher and Consumer permits-counter and that can prevent possible consumer-message blocking.