Don't run Runtime#halt in tests #7066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you trigger Runtime#halt from a test, as was happening on ZK session loss, it kills the test without reporting a result. We shouldn't do that. Instead, reserve halt for production code, and just log for tests.
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
jerrypeng,
aahmed-se and
codelipenghui
sijie
approved these changes
May 28, 2020
315157973
pushed a commit
to 315157973/pulsar
that referenced
this pull request
May 29, 2020
When you trigger Runtime#halt from a test, as was happening on ZK session loss, it kills the test without reporting a result. We shouldn't do that. Instead, reserve halt for production code, and just log for tests. Co-authored-by: Ivan Kelly <ikelly@splunk.com>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
When you trigger Runtime#halt from a test, as was happening on ZK session loss, it kills the test without reporting a result. We shouldn't do that. Instead, reserve halt for production code, and just log for tests. Co-authored-by: Ivan Kelly <ikelly@splunk.com>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
When you trigger Runtime#halt from a test, as was happening on ZK session loss, it kills the test without reporting a result. We shouldn't do that. Instead, reserve halt for production code, and just log for tests. Co-authored-by: Ivan Kelly <ikelly@splunk.com>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 12, 2020
When you trigger Runtime#halt from a test, as was happening on ZK session loss, it kills the test without reporting a result. We shouldn't do that. Instead, reserve halt for production code, and just log for tests. Co-authored-by: Ivan Kelly <ikelly@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
When you trigger Runtime#halt from a test, as was happening on ZK session loss, it kills the test without reporting a result. We shouldn't do that. Instead, reserve halt for production code, and just log for tests. Co-authored-by: Ivan Kelly <ikelly@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When you trigger Runtime#halt from a test, as was happening on ZK
session loss, it kills the test without reporting a result. We
shouldn't do that. Instead, reserve halt for production code, and just
log for tests.