MockZooKeeper#failNow is unreliable #7109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MockZooKeeper#failNow instructs the MockZooKeeper instance to fail the next call to zookeeper. In a multithreaded system with many things accessing zookeeper, using #failNow is unreliable, as a background thread could try to access ZK before the call that is actually under tests accesses it. This change tightens the condition on which the failed ZK call can occur, by checking the operation type and path. This resolves a flake that was occuring in ZooKeeperSessionExpiryRecoveryTest.
merlimat
added
type/enhancement
codelipenghui
approved these changes
Jun 1, 2020
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 12, 2020
* MockZooKeeper#failNow is unreliable The MockZooKeeper#failNow instructs the MockZooKeeper instance to fail the next call to zookeeper. In a multithreaded system with many things accessing zookeeper, using #failNow is unreliable, as a background thread could try to access ZK before the call that is actually under tests accesses it. This change tightens the condition on which the failed ZK call can occur, by checking the operation type and path. This resolves a flake that was occuring in ZooKeeperSessionExpiryRecoveryTest. * Fixed import missing after merge Co-authored-by: Ivan Kelly <ikelly@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* MockZooKeeper#failNow is unreliable The MockZooKeeper#failNow instructs the MockZooKeeper instance to fail the next call to zookeeper. In a multithreaded system with many things accessing zookeeper, using #failNow is unreliable, as a background thread could try to access ZK before the call that is actually under tests accesses it. This change tightens the condition on which the failed ZK call can occur, by checking the operation type and path. This resolves a flake that was occuring in ZooKeeperSessionExpiryRecoveryTest. * Fixed import missing after merge Co-authored-by: Ivan Kelly <ikelly@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
MockZooKeeper#failNowinstructs theMockZooKeeperinstance to failthe next call to zookeeper. In a multithreaded system with many things
accessing zookeeper, using
#failNowis unreliable, as a backgroundthread could try to access ZK before the call that is actually under
tests accesses it.
This change tightens the condition on which the failed ZK call can
occur, by checking the operation type and path. This resolves a flake
that was occurring in
ZooKeeperSessionExpiryRecoveryTest.