Add numMessagesInQueue and getAvailablePermits for PartitionedConsumer #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
merlimat
reviewed
Oct 18, 2016
| @@ -398,6 +398,14 @@ public boolean isBatchingAckTrackerEmpty() { | |||
| return consumers; | |||
| } | |||
|
|
|||
| public int getAvailablePermits() { | |||
There was a problem hiding this comment.
The interface for these 2 methods could also be added to ConsumerBase abstract class, to avoid need to downcast and checking the type of the consumer implementation
|
@sschepens I'm seeing there is a test failure here that appears to be intermittent and related to the per-message redelivery change : I think the receive timeouts of 10ms are too low and can lead to this spurious errors, especially in Travis which runs the test in a Docker container and it appears to lead to very funny timing issues. Try to raise that to at least 100ms. |
|
@merlimat will do |
sschepens
force-pushed
the
partitioned_methods
branch
from
2731497 to
8ec9f88
Compare
merlimat
approved these changes
Oct 18, 2016
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* More graceful warning when args are missing * Make use of Annotations * Tests work
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 11, 2022
* [feat][elasticsearch] Add hashed id support * add config default test (cherry picked from commit 4fdb34e)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 11, 2022
* [feat][elasticsearch] Add hashed id support * add config default test
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow a partitioned consumer to get the available messages to consume
Modifications
Added
numMessagesInQueueandgetAvailablePermitsforPartitionedConsumerResult
A Partitioned consumer can now get the amount of messages it has to consume.