Fixed readers backlog stats after data is skipped #7236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
changed the title
jerrypeng
approved these changes
Jun 11, 2020
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
Outdated
Show resolved
Hide resolved
| PositionImpl highestPositionToDelete = new PositionImpl(firstNonDeletedLedger, -1); | ||
|
|
||
| cursors.forEach(cursor -> { | ||
| if (highestPositionToDelete.compareTo((PositionImpl) cursor.getMarkDeletedPosition()) > 0) { |
There was a problem hiding this comment.
Shall we need to add check for non-durable cursor?
There was a problem hiding this comment.
No need for that, a durable cursor would have been already moved ahead, otherwise we wouldn't be trimming that ledger.
Comment on lines
+711
to
+712
| assertEquals(nonDurableCursor.getNumberOfEntries(), 6); | ||
| assertEquals(nonDurableCursor.getNumberOfEntriesInBacklog(true), 6); |
There was a problem hiding this comment.
Why durable cursor has 5 backlogs, non-durable cursor has 6 backlogs? Shouldn't they be the same?
There was a problem hiding this comment.
That's because the other cursor is positioned at the end of the 5th ledger, but not on the 6th. That means that only 4 ledgers are deleted. That cursor would move forward on the next mark-delete.
When advancing the non-durable cursor, we advance to the first available ledger and that might be before the durable cursor mark-delete position, but that's ok.
…l/ManagedLedgerImpl.java Co-authored-by: lipenghui <penghui@apache.org>
codelipenghui
approved these changes
Jun 12, 2020
aahmed-se
approved these changes
Jun 12, 2020
sijie
approved these changes
Jun 15, 2020
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jul 14, 2020
### Motivation The metrics for the reader backlog keep increasing when data is dropped because the reader cursor only moves on the next read attempt. Instead we should proactively move the cursor forward on the first valid ledger. (cherry picked from commit 6b9c90f)
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
### Motivation The metrics for the reader backlog keep increasing when data is dropped because the reader cursor only moves on the next read attempt. Instead we should proactively move the cursor forward on the first valid ledger. (cherry picked from commit 6b9c90f)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation The metrics for the reader backlog keep increasing when data is dropped because the reader cursor only moves on the next read attempt. Instead we should proactively move the cursor forward on the first valid ledger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The metrics for the reader backlog keep increasing when data is dropped because the reader cursor only moves on the next read attempt.
Instead we should proactively move the cursor forward on the first valid ledger.