GPG keys need to imported just once #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
merlimat
added a commit
that referenced
this pull request
Oct 27, 2016
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* adding some log messages * fixing
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Motivation: code is not fmt, should be with gofmt Modifications: - gofmt once Fixes apache#74 Change-Id: Ic4eb14080bb0da22be418ff1385d90209f2b9d27
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 11, 2022
…icData.Array and Utf8 map keys) (apache#75)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During release process, there are 2 deploy phases, once for Sonatype and one for GitHub releases upload. The
before_deployscript is current being executed twice and fails the 2nd time.Modifications
Import the GPG keys just once in the
before_scriptphase.Result
Releases tar.gz files will be automatically uploaded to github.