Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed race condition in ProxyPublishConsumeTest #770

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

merlimat
Copy link
Contributor

Motivation

The check condition on the number of message received by the reader was not correct. Also, the onConnect() event is actually triggered before the consumer has been fully established, so added sleep to account for that.

@merlimat merlimat added this to the 1.21.0-incubating milestone Sep 20, 2017
@merlimat merlimat self-assigned this Sep 20, 2017
@merlimat
Copy link
Contributor Author

This should finally fix #237

@merlimat merlimat requested a review from jai1 September 20, 2017 17:48
Copy link
Contributor

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit b53a5dc into apache:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants