Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Intermittent test failure for MessageDispatchThrottlingTest #771

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Fix Intermittent test failure for MessageDispatchThrottlingTest #771

merged 1 commit into from
Sep 20, 2017

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Sep 20, 2017 •
edited
Loading

Motivation

Fix Intermittent test failure for MessageDispatchThrottlingTest : reduced message-rate to make sure broker can throttle for longer time and verify consumed message throttling.

Failure:

[^[[1;31mERROR^[[m] testClusterMsgByteRateLimitingClusterConfig(org.apache.pulsar.client.api.MessageDispatchThrottlingTest)  Time elapsed: 3.214 s  <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
        at org.apache.pulsar.client.api.MessageDispatchThrottlingTest.testClusterMsgByteRateLimitingClusterConfig(MessageDispatchThrottlingTest.java:282)

[^[[1;31mERROR^[[m] testClusterRateLimitingConfiguration(org.apache.pulsar.client.api.MessageDispatchThrottlingTest)  Time elapsed: 2.501 s  <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
        at org.apache.pulsar.client.api.MessageDispatchThrottlingTest.testClusterRateLimitingConfiguration(MessageDispatchThrottlingTest.java:555)

@rdhabalia rdhabalia added this to the 1.20.0-incubating milestone Sep 20, 2017
@rdhabalia rdhabalia self-assigned this Sep 20, 2017
@merlimat
Copy link
Contributor

@rdhabalia Did you try to run the test multiple time (eg: invocationCount=100)?

@rdhabalia
Copy link
Contributor Author

Did you try to run the test multiple time

yes, I have run with invocationCount=50 but now running with higher invocationCount=150 to make sure we won't miss any boundary case.

@merlimat
Copy link
Contributor

it didn't pick up the status change

@rdhabalia rdhabalia mentioned this pull request Sep 20, 2017
Closed
@merlimat merlimat merged commit 94b1fb9 into apache:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@rdhabalia rdhabalia

Labels
area/test
Projects
None yet
Milestone
1.20.0-incubating
Development

Successfully merging this pull request may close these issues.
2 participants
@rdhabalia @merlimat