Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored replicator test with backlog quota interactions #773

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Refactored replicator test with backlog quota interactions #773

merged 1 commit into from
Sep 21, 2017

Conversation

merlimat
Copy link
Contributor

Motivation

The logic for the replicator test with the backlog quota check was not correct.

We need to make sure that the quota gets filled, in order to cause remote backlog, and then drain the backlog when the quota is available.

Modifications

Refactored the test to do:

  • Create 2 regions r1 and r2
  • Created local subscription on r2
  • Initially quota is open
  • Publish message m1 in r1. It gets replicated
  • Reduce quota to fit just 1 message
  • Publish next message m2 in r1
  • Verify message is in remote backlog
  • Consume m1 in r2
  • Verify m2 gets replicated and consumed

@merlimat merlimat added this to the 1.20.0-incubating milestone Sep 20, 2017
@merlimat merlimat self-assigned this Sep 20, 2017
rdhabalia
rdhabalia approved these changes Sep 20, 2017
View reviewed changes
Copy link
Contributor

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat
Copy link
Contributor Author

retest this please

1 similar comment
@rdhabalia
Copy link
Contributor

retest this please

@merlimat merlimat merged commit 8bf8eb1 into apache:master Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdhabalia rdhabalia rdhabalia approved these changes

@saandrews saandrews Awaiting requested review from saandrews

@joefk joefk Awaiting requested review from joefk

@nkurihar nkurihar Awaiting requested review from nkurihar

Assignees

@merlimat merlimat

Labels
area/test
Projects
None yet
Milestone
1.20.0-incubating
Development

Successfully merging this pull request may close these issues.
2 participants
@merlimat @rdhabalia