Close topics after creating all subscriptions on increment-partitions #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
force-pushed
the
test_part
branch
from
9ead0ba to
f41dc3e
Compare
rdhabalia
force-pushed
the
test_part
branch
from
f41dc3e to
3df445c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, while incrementing-partitions for topic which has multiple subscribers (cursors): broker creates a topic for every cursor and then close it. So, if topic has multiple subscribers then multiple cursor tries to create and close topic which will give exception that
topic is fenced or ledger is already closed. Therefore, broker should close all the newly created topics only once aftercreation of subscriptionprocess is done.Modifications
Close topics once all the subscriptions created successfully.
Result
Broker will be able to update new partitioned without any intermittent issue.