Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment receive timeout on PerMessageUnAcknowledgedRedeliveryTest #85

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

sschepens
Copy link
Contributor

Increment timeouts on PerMessageUnAcknowledgedRedeliveryTest to prevent failing tests

@yahoocla
Copy link

CLA is valid!

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit 776042b into apache:master Oct 25, 2016
@sschepens sschepens deleted the fix_redelivery_timeouts branch October 25, 2016 17:25
@merlimat merlimat added this to the 1.16 milestone Oct 25, 2016
sijie added a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
* Fix upload path issue

* fix logging
massakam pushed a commit to massakam/pulsar that referenced this pull request Aug 6, 2020
Since we don’t have reference for the client, v8 can garbage collect this instance, which can cause the next code:

```
const Pulsar = require('pulsar-client');

(async () => {
  // Create a client
  const client = new Pulsar.Client({
    serviceUrl: 'pulsar://localhost:6650'
  });

  // Create a producer
  const producer = await client.createProducer({
    topic: 'persistent://public/default/my-topic',
    sendTimeoutMs: 30000,
    batchingEnabled: true,
  });

  let i =0;
  async function produceMessage() {
    i = i + 1;

    const msg = `my-message-${i}`;
    const ret = await producer.send({
      data: Buffer.from(msg),
    });
    console.log(`Sent message: ${msg}`);
    console.log(ret);

    setTimeout(produceMessage, 1000);
  }

  produceMessage();
})();
```

To close the connection suddenly and fail the producer.
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
…he#85)

* fix issue 84, NPE while enable broker publish throttling

* fix check

while set
```
brokerPublisherThrottlingMaxByteRate
```
it will meet NPE error.

This is caused by the mock Producer that we registered for bundle load/unload handling. 
change: provide a mock method in InternalServerCnx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants