PIP-75: Perform serialization/deserialization with LightProto #9046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
rdhabalia,
jerrypeng and
codelipenghui
eolivelli
approved these changes
Dec 24, 2020
rdhabalia
approved these changes
Dec 24, 2020
sijie
requested changes
Dec 30, 2020
@rdhabalia Not yet, this is a big change against a target that is moving very fast (master). There is no way this can go to production before getting merged to master first, though it will surely get extensively tested before the 2.8 release. Also, we need to differentiate the 2 aspect:
@sijie Good point, the micro-benchmark in https://github.com/splunk/lightproto is based on the default Protobuf 3.13. I've added a new benchmark targeting Pulsar specific serizalization at https://github.com/merlimat/LightProtoPulsarBenchmark |
|
@sijie PTAL since every days there are new conflicts to fix |
|
@merlimat sorry. I am reviewing it today. |
sijie
approved these changes
Jan 4, 2021
1 task
zymap
added a commit
to zymap/pulsar
that referenced
this pull request
Jan 13, 2021
--- *Motivation* We introduce a new way to handle the proto and remove the 'protobuf-shaded/pom.xml' in the PR apache#9046. We need to remove the set version in the scripts.
sijie
pushed a commit
that referenced
this pull request
Jan 14, 2021
--- *Motivation* We introduce a new way to handle the proto and remove the 'protobuf-shaded/pom.xml' in the PR #9046. We need to remove the set version in the scripts.
This was referenced Mar 31, 2021
sijie
pushed a commit
that referenced
this pull request
Apr 9, 2021
Fixes: #10097 ### Motivation See #10097 for the issue. It seems that the code broke when the switch was made to LightProto in #9046. ### Modifications It is necessary to use `msg.getMessageBuilder().hasReplicatedFrom()` and use logic that only calls `msg.getMessageBuilder().getReplicatedFrom()` if `hasReplicatedFrom()` returns true.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As explained in https://github.com/apache/pulsar/wiki/PIP-75%3A-Replace-protobuf-code-generator , replace the patched Google Protobuf serialization with LightProto.