Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The unit of consumeTimeout in RocketMQ-Spring is inconsistent with that of RocketMQ client #241

Closed
wzqiang1332 opened this issue Mar 24, 2020 · 2 comments · Fixed by #247
Closed

The unit of consumeTimeout in RocketMQ-Spring is inconsistent with that of RocketMQ client #241

wzqiang1332 opened this issue Mar 24, 2020 · 2 comments · Fixed by #247
Labels
bug Something isn't working
Milestone
2.1.1

Comments

@wzqiang1332
Copy link

  • rocketmq-client:4.6
  • rocketmq-spring-boot-starter:2.1.0

配置与rocketmq-client不一致， rocketmq-client里面是以分钟计算

org.apache.rocketmq.spring.annotation.RocketMQMessageListener

/**
  * Max consumer timeout, default 30s.
  */
long consumeTimeout() default 30000L;`

org.apache.rocketmq.client.consumer.DefaultMQPushConsumer

/**
  * Maximum amount of time in minutes a message may block the consuming thread.
  */
private long consumeTimeout = 15;
@RongtongJin RongtongJin added the bug Something isn't working label Mar 24, 2020
@RongtongJin RongtongJin added this to the 2.1.1 milestone Mar 24, 2020
@RongtongJin
Copy link
Contributor

RongtongJin commented Mar 24, 2020 •
edited
Loading

It‘s indeed a bug. Could you please submit a PR to slove this issue？

@RongtongJin RongtongJin changed the title consumeTimeout的设置与rocketmq-client单位不一致 The unit of consumeTimeout in RocketMQ-Spring is inconsistent with that of RocketMQ client Mar 24, 2020
@RongtongJin
Copy link
Contributor

I will fix it.

@RongtongJin RongtongJin mentioned this issue Apr 1, 2020
Merged
6 tasks
ShannonDing pushed a commit that referenced this issue Apr 3, 2020
@RongtongJin
[ISSUE #241] Make the unit of consumeTimeout in rocketmq-spring consi…
1464698 
…stent with rocketmq client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.1
2 participants
@wzqiang1332 @RongtongJin