Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The versions in samples are not same #314

Closed
WreathCrystal opened this issue Nov 25, 2020 · 3 comments · Fixed by #316
Closed

The versions in samples are not same #314

WreathCrystal opened this issue Nov 25, 2020 · 3 comments · Fixed by #316

Comments

@WreathCrystal
Copy link

The issue tracker is ONLY used for bug report and feature request.

Any question or RocketMQ proposal please use our mailing lists.

BUG REPORT

  1. Please describe the issue you observed:
  • What did you do (The steps to reproduce)?
    I want to compile the samples project.

  • What did you expect to see?
    I expected no errors occur.

  • What did you see instead?
    There is no rocketmq-spring-boot-samples-2.1.1-SNAPSHOT.jar found.

  1. Please tell us about your environment:
    Please see the screeshots. Version difference can be found
    1606286272(1)
    1606286309(1)

.

  1. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):

FEATURE REQUEST

  1. Please describe the feature you are requesting.

  2. Provide any additional detail on your proposed use case for this feature.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

@RongtongJin
Copy link
Contributor

Good catch!Could you submit a pull request to fix the issue?

@WreathCrystal
Copy link
Author

Sure

@WreathCrystal
Copy link
Author

Good catch!Could you submit a pull request to fix the issue?

When I compile samples on my pc in order to fix the issue, errors occur as below
checkstyle-failed

I think , I need solve this problem before summitting my request. But I don not know how to checkstyle sucessfully.

vongosling added a commit that referenced this issue Nov 26, 2020
[ISSUE #314]  Modify  parent.versions of  modules  in  samples project  from 2.1.1-SNAPSHOT to 2.1.2-SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants