Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow programmatic modify @RocketMQMessageListener annotation properties #479

Closed
kosmosr opened this issue Aug 5, 2022 · 3 comments · Fixed by #480
Closed

Allow programmatic modify @RocketMQMessageListener annotation properties #479

kosmosr opened this issue Aug 5, 2022 · 3 comments · Fixed by #480

Comments

@kosmosr
Copy link
Contributor

kosmosr commented Aug 5, 2022

FEATURE REQUEST

  1. Please describe the feature you are requesting.
    In a jvm process, I can define different @RocketMQMessageListener annotations on the prototype bean and programmatically set the different annotation properties, such as consumerGroup
  2. Provide any additional detail on your proposed use case for this feature.
    reference kafka impl: https://docs.spring.io/spring-kafka/docs/current/reference/html/#kafkalistener-attrs
    I've finished coding and can request pr
  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
    should-have and no other way to do it
@panzhi33
Copy link
Contributor

panzhi33 commented Aug 8, 2022

Means that @RocketMQMessageListener annotations do not set value, programmatically modify annotation attributes before the container is created？

@kosmosr
Copy link
Contributor Author

kosmosr commented Aug 8, 2022

Means that @RocketMQMessageListener annotations do not set value, programmatically modify annotation attributes before the container is created？

yes

@panzhi33
Copy link
Contributor

panzhi33 commented Aug 9, 2022

good，you can submit your pr to have a look

kosmosr added a commit to kosmosr/rocketmq-spring that referenced this issue Aug 9, 2022
@kosmosr
[ISSUE apache#479]Allow programmatic modify @RocketMQMessageListener …
61ca676 
…annotation properties
@kosmosr kosmosr mentioned this issue Aug 9, 2022
Merged
6 tasks
@ShannonDing ShannonDing linked a pull request Aug 16, 2022 that will close this issue
[ISSUE #479] Allow programmatic modify @RocketMQMessageListener annota… #480
Merged
6 tasks
ShannonDing pushed a commit that referenced this issue Sep 6, 2022
@kosmosr
[ISSUE #479] Allow programmatic modify @RocketMQMessageListener annot…
607a0ef 
…a… (#480)

* [ISSUE #479]Allow programmatic modify @RocketMQMessageListener annotation properties

* add unit test

* add unit test with License
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #479] Allow programmatic modify @RocketMQMessageListener annota… kosmosr/rocketmq-spring
2 participants
@kosmosr @panzhi33