Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #147]An enhancement about the convert in RocketMQTemplate #152

Merged
merged 6 commits into from
Nov 11, 2019
Merged

[ISSUE #147]An enhancement about the convert in RocketMQTemplate #152

merged 6 commits into from
Nov 11, 2019

Conversation

zkzlx
Copy link
Contributor

@zkzlx zkzlx commented Sep 29, 2019

What is the purpose of the change

An enhancement about the convert in RocketMQTemplate

Brief changelog

enhancement #147

Do not use ObjectMapper directly, Instead, the externally built converter is injected into MessageConverter in RocketMQTemplate.

a piece of code in RocketMQMessageConverter :

public RocketMQMessageConverter() {
	List<MessageConverter> messageConverters = new ArrayList<>();
	ByteArrayMessageConverter byteArrayMessageConverter = new ByteArrayMessageConverter();
	byteArrayMessageConverter.setContentTypeResolver(null);
	messageConverters.add(byteArrayMessageConverter);
	messageConverters.add(new StringMessageConverter());
	if (JACKSON_PRESENT) {
		messageConverters.add(new MappingJackson2MessageConverter());
	}
	if (FASTJSON_PRESENT) {
		try {
			messageConverters.add(
				(MessageConverter)ClassUtils.forName(
					"com.alibaba.fastjson.support.spring.messaging.MappingFastJsonMessageConverter",
					ClassUtils.getDefaultClassLoader()).newInstance());
		} catch (ClassNotFoundException | IllegalAccessException | InstantiationException e) {
		}
	}
	messageConverter = new CompositeMessageConverter(messageConverters);
}

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@zkzlx
Copy link
Contributor Author

zkzlx commented Oct 8, 2019

@vongosling Please take a look

@zkzlx
Copy link
Contributor Author

zkzlx commented Oct 13, 2019

@RongtongJin @vongosling I was solved , you can check it now. thanks .

@RongtongJin
Copy link
Contributor

LGTM~

@vongosling vongosling changed the title An enhancement about the convert in RocketMQTemplate [ISSUE#147]An enhancement about the convert in RocketMQTemplate Oct 28, 2019
@vongosling vongosling changed the title [ISSUE#147]An enhancement about the convert in RocketMQTemplate [ISSUE #147]An enhancement about the convert in RocketMQTemplate Oct 28, 2019
@vongosling vongosling merged commit 8b2426e into apache:master Nov 11, 2019
@vongosling vongosling added this to the 2.0.4 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants