Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #506] support send message with arbitrarily delay time #515

Merged
merged 3 commits into from
Jan 29, 2023

Conversation

zhouchunhai
Copy link
Contributor

What is the purpose of the change

support send message with arbitrarily delay time

Brief changelog

upgrade rocketmq client version to 5.0.0.
add api in RocketMqTemplate to support send message with arbitrarily delay time

Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to expose the relevant interfaces of delayTimeMs and deliverTimeMs

Comment on lines +551 to +558
/**
* Same to {@link #syncSend(String, Object)} with send delayTime specified in addition.
*
* @param destination formats: `topicName:tags`
* @param payload the Object to use as payload
* @param delayTime delay time in seconds for message
* @return {@link SendResult}
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to remind users that the interface can only take effect on RocketMQ 5.0 servers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,I will make it better and try to support batch messages and orderly message both sync and async.

@RongtongJin
Copy link
Contributor

Hi @zhouchunhai I'm going to merge this pr first, and then release a new version for rocketmq-spring.

@RongtongJin RongtongJin merged commit 243820c into apache:master Jan 29, 2023
@RongtongJin RongtongJin added this to the 2.2.3 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants