Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #96] resolve the placeholder for "listener.txProducerGroup()" #97

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

brucevoin
Copy link

What is the purpose of the change

#96 resolve the placeholder for "listener.txProducerGroup()"

Brief changelog

resolve the placeholder for "listener.txProducerGroup()" in file RocketMQTransactionAnnotationProcessor.java

Verifying this change

when add TransactionListener like this :

@RocketMQTransactionListener(txProducerGroup = "${demo.rocketmq.transaction.producer.group}")
class TransactionListenerImpl implements RocketMQLocalTransactionListener {
    private static final Logger LOGGER = LoggerFactory.getLogger(TransactionListenerImpl.class);

    private AtomicInteger transactionIndex = new AtomicInteger(0);

    private ConcurrentHashMap<String, Integer> localTrans = new ConcurrentHashMap<>();

the txProducerGroup can be injected from configuation like application.properties file.

@vongosling
Copy link
Member

@fenghaichun Could you add some test for the pr?

@brucevoin
Copy link
Author

brucevoin commented Jul 26, 2019

@fenghaichun Could you add some test for the pr?

I have added the unit test for this PR, please check it out for me, thank you very much.

@brucevoin
Copy link
Author

@vongosling The CI have failed, and it says "jdk_switcher: command not found", i don't know how to resolve it, can you help me to check this problem?

@vongosling
Copy link
Member

vongosling commented Jul 29, 2019

@fenghaichun Thanks. Travis moved forward to be not compatible with the old configuration. we will fix it after merging your pr.

@vongosling
Copy link
Member

@fenghaichun #109

@vongosling vongosling merged commit cc1a340 into apache:master Jul 29, 2019
@vongosling vongosling added the enhancement New feature or request label Jul 29, 2019
@vongosling vongosling added this to the 2.0.4 milestone Jul 29, 2019
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this pull request Mar 26, 2020
[ISSUE apache#96] resolve the placeholder for "listener.txProducerGroup()"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants