[ISSUE #8396] Fix typo in TraceConstants (#8398)

* [ISSUE #8396] Fix typo in TraceConstants * Update * Update * Update * Update * Update * Update
apache · Jul 18, 2024 · 852b635 · 852b635
1 parent 2d1e314
commit 852b635
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/TraceConstants.java b/client/src/main/java/org/apache/rocketmq/client/trace/TraceConstants.java
@@ -32,7 +32,7 @@ public class TraceConstants {
     public static final String ROCKETMQ_SUCCESS = "rocketmq.success";
     public static final String ROCKETMQ_TAGS = "rocketmq.tags";
     public static final String ROCKETMQ_KEYS = "rocketmq.keys";
-    public static final String ROCKETMQ_SOTRE_HOST = "rocketmq.store_host";
+    public static final String ROCKETMQ_STORE_HOST = "rocketmq.store_host";
     public static final String ROCKETMQ_BODY_LENGTH = "rocketmq.body_length";
     public static final String ROCKETMQ_MSG_ID = "rocketmq.mgs_id";
     public static final String ROCKETMQ_MSG_TYPE = "rocketmq.mgs_type";

diff --git a/...rc/main/java/org/apache/rocketmq/client/trace/hook/EndTransactionOpenTracingHookImpl.java b/...rc/main/java/org/apache/rocketmq/client/trace/hook/EndTransactionOpenTracingHookImpl.java
@@ -60,7 +60,7 @@ public void endTransaction(EndTransactionContext context) {
         span.setTag(Tags.MESSAGE_BUS_DESTINATION, msg.getTopic());
         span.setTag(TraceConstants.ROCKETMQ_TAGS, msg.getTags());
         span.setTag(TraceConstants.ROCKETMQ_KEYS, msg.getKeys());
-        span.setTag(TraceConstants.ROCKETMQ_SOTRE_HOST, context.getBrokerAddr());
+        span.setTag(TraceConstants.ROCKETMQ_STORE_HOST, context.getBrokerAddr());
         span.setTag(TraceConstants.ROCKETMQ_MSG_ID, context.getMsgId());
         span.setTag(TraceConstants.ROCKETMQ_MSG_TYPE, MessageType.Trans_msg_Commit.name());
         span.setTag(TraceConstants.ROCKETMQ_TRANSACTION_ID, context.getTransactionId());

diff --git a/...t/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageOpenTracingHookImpl.java b/...t/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageOpenTracingHookImpl.java
@@ -60,7 +60,7 @@ public void sendMessageBefore(SendMessageContext context) {
         span.setTag(Tags.MESSAGE_BUS_DESTINATION, msg.getTopic());
         span.setTag(TraceConstants.ROCKETMQ_TAGS, msg.getTags());
         span.setTag(TraceConstants.ROCKETMQ_KEYS, msg.getKeys());
-        span.setTag(TraceConstants.ROCKETMQ_SOTRE_HOST, context.getBrokerAddr());
+        span.setTag(TraceConstants.ROCKETMQ_STORE_HOST, context.getBrokerAddr());
         span.setTag(TraceConstants.ROCKETMQ_MSG_TYPE, context.getMsgType().name());
         span.setTag(TraceConstants.ROCKETMQ_BODY_LENGTH, msg.getBody().length);
         context.setMqTraceContext(span);

diff --git a/.../src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithOpenTracingTest.java b/.../src/test/java/org/apache/rocketmq/client/trace/DefaultMQProducerWithOpenTracingTest.java
@@ -124,7 +124,7 @@ public void testSendMessageSync_WithTrace_Success() throws RemotingException, In
         assertThat(span.tags().get(TraceConstants.ROCKETMQ_BODY_LENGTH)).isEqualTo(3);
         assertThat(span.tags().get(TraceConstants.ROCKETMQ_REGION_ID)).isEqualTo("HZ");
         assertThat(span.tags().get(TraceConstants.ROCKETMQ_MSG_TYPE)).isEqualTo(MessageType.Normal_Msg.name());
-        assertThat(span.tags().get(TraceConstants.ROCKETMQ_SOTRE_HOST)).isEqualTo("127.0.0.1:10911");
+        assertThat(span.tags().get(TraceConstants.ROCKETMQ_STORE_HOST)).isEqualTo("127.0.0.1:10911");
     }
 
     @After