Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add more test coverage for DefaultMQPushConsumerImpl #8411

Closed
1 task done
yx9o opened this issue Jul 19, 2024 · 2 comments · Fixed by #8412
Closed
1 task done

[Enhancement] Add more test coverage for DefaultMQPushConsumerImpl #8411

yx9o opened this issue Jul 19, 2024 · 2 comments · Fixed by #8412
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on type/enhancement

Comments

@yx9o
Copy link
Contributor

yx9o commented Jul 19, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Add more tests.

Motivation

Add more tests.

Describe the Solution You'd Like

Add more tests.

Describe Alternatives You've Considered

No

Additional Context

No response
yx9o added a commit to yx9o/rocketmq that referenced this issue Jul 19, 2024
@yx9o
[ISSUE apache#8411] Add more test coverage for DefaultMQPushConsumerImpl
6eee544
@yx9o yx9o mentioned this issue Jul 19, 2024
Merged
@ShannonDing ShannonDing added the soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on label Jul 19, 2024
@ShannonDing
Copy link
Member

link #8262

@yx9o
Copy link
Contributor Author

yx9o commented Jul 19, 2024

link #8262

OK, I didn't pay attention to this issue before, but I saw this RIP: https://github.com/apache/rocketmq/wiki/RIP-10-RocketMQ-Unit-Test

I will quote #8262 later.

RongtongJin pushed a commit that referenced this issue Jul 22, 2024
@yx9o
[ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#…
bd61774 
…8412)

* [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl

* Update

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl yx9o/rocketmq
2 participants
@yx9o @ShannonDing