Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] DoAppend function of CommitLog class annotation optimize #8448

Closed
1 task done
Qoozm opened this issue Jul 26, 2024 · 0 comments · Fixed by #8452
Closed
1 task done

[Enhancement] DoAppend function of CommitLog class annotation optimize #8448

Qoozm opened this issue Jul 26, 2024 · 0 comments · Fixed by #8452

Comments

@Qoozm
Copy link
Contributor

Qoozm commented Jul 26, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

This is a annotation optimize about CommitLog's doAppend function

Motivation

Hi Community!
As a newcomer, annotation is important for me to read and understand the code, when i was learned about store flow, i find there are some fuzzy annotation.

1721975033085

  1. There are't explain of pos init
  2. There are two problem
    1. The first 8 belong to PHYSICALOFFSET but SYSFLAG,, maybe we should add 8 to pos after line 1972
    2. "11 STORETIMESTAMP" annotation should at 1977
  3. The UtilAll.crc32 function will change buffer's position index, add a annotation is more clear

Describe the Solution You'd Like

Here is my optimization plan.
image

Describe Alternatives You've Considered

no

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant