Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add more test coverage for BrokerMetricsManager #8486

Closed
1 task done
ziiyee opened this issue Aug 3, 2024 · 1 comment · Fixed by #8487
Closed
1 task done

[Enhancement] Add more test coverage for BrokerMetricsManager #8486

ziiyee opened this issue Aug 3, 2024 · 1 comment · Fixed by #8487
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on type/enhancement

Comments

@ziiyee
Copy link
Contributor

ziiyee commented Aug 3, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Add more test coverage for BrokerMetricsManager

Motivation

add more tests

Describe the Solution You'd Like

add more tests

Describe Alternatives You've Considered

add more tests

Additional Context

before
Pasted Graphic 2

after
Pasted Graphic 1
@ziiyee ziiyee mentioned this issue Aug 3, 2024
Merged
@ziiyee
Copy link
Contributor Author

ziiyee commented Aug 3, 2024

link #8262

@ShannonDing ShannonDing added the soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on label Aug 5, 2024
ShannonDing pushed a commit that referenced this issue Aug 7, 2024
@ziiyee
[ISSUE #8486]Add more test coverage for BrokerMetricsManager (#8487)
cba8a64 
* Add more test case for BrokerMetricsManager. Includes:
- check the topic is retry or dlq topic
- check the group is system group or not
- check the topic and the group belongs to system or not

* Add more test case for BrokerMetricsManager. Check topic message type by request header.

* Add more test case for BrokerMetricsManager.

* Add more test case for BrokerMetricsManager.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8486]Add more test coverage for BrokerMetricsManager ziiyee/rocketmq
2 participants
@ShannonDing @ziiyee