Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Fix workflow Coverage failure due to testProduceAccumulator_sync() #8499

Closed
1 task done
imzs opened this issue Aug 6, 2024 · 3 comments · Fixed by #8522
Closed
1 task done

[Enhancement] Fix workflow Coverage failure due to testProduceAccumulator_sync() #8499

imzs opened this issue Aug 6, 2024 · 3 comments · Fixed by #8522
Labels
type/enhancement

Comments

@imzs
Copy link
Contributor

imzs commented Aug 6, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

https://github.com/apache/rocketmq/actions/workflows/coverage.yml
Most of the recent Coverage workflow tasks failed at ProduceAccumulatorTest#testProduceAccumulator_sync(), it's necessary to fix it.

image

https://github.com/apache/rocketmq/actions/runs/10229250411/job/28302677991
https://github.com/apache/rocketmq/actions/runs/10242303444/job/28331811381
https://github.com/apache/rocketmq/actions/runs/10250136206/job/28355136628
https://github.com/apache/rocketmq/actions/runs/10251927612/job/28361102144
https://github.com/apache/rocketmq/actions/runs/10251005385/job/28358033934
https://github.com/apache/rocketmq/actions/runs/10241255714/job/28329267351

Motivation

.

Describe the Solution You'd Like

Tests run: 3, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 0.264 sec <<< FAILURE! - in org.apache.rocketmq.client.producer.ProduceAccumulatorTest
testProduceAccumulator_sync(org.apache.rocketmq.client.producer.ProduceAccumulatorTest) Time elapsed: 0.133 sec <<< FAILURE!
org.opentest4j.AssertionFailedError:
expected: 175
but was: 37

Describe Alternatives You've Considered

.

Additional Context

No response
@imzs imzs changed the title [Enhancement] fix workflow Coverage failure due to testProduceAccumulator_sync() [Enhancement] Fix workflow Coverage failure due to testProduceAccumulator_sync() Aug 6, 2024
imzs added a commit to imzs/rocketmq that referenced this issue Aug 6, 2024
@imzs
[ISSUE apache#8499] fix workflow Coverage failure due to testProduceA…
a9da1d0 
…ccumulator_sync(), hold for more time
imzs added a commit to imzs/rocketmq that referenced this issue Aug 6, 2024
@imzs
[ISSUE apache#8499] fix workflow Coverage failure due to testProduceA…
078804d 
…ccumulator_sync(), hold for more time
@ShannonDing
Copy link
Member

could you pls submit a PR to fix it.

This was referenced Aug 8, 2024
Merged
Merged
@imzs
Copy link
Contributor Author

imzs commented Aug 12, 2024

could you pls submit a PR to fix it.

Chair Ding, as I've tested, 1000ms may not be enough.

@ShannonDing
Copy link
Member

testProduceAccumulator_sync

OK, let‘s reset it to 3s and let countDownLatch await 5s.

ShannonDing added a commit that referenced this issue Aug 13, 2024
@ShannonDing
[ISSUE #8499]Modify batch send delay time to 3000ms in unit test. (#8522
fa0cd49 
)

* modify batch send delay time to 3000ms in unit test.

* close unittest in macOS platform.

* close unittest in macOS platform checking.

* close broker regest timeout unittest in macOS platform checking.

* close broker regest timeout unittest in macOS platform checking.

* modify batch send delay time to 3000ms in unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8499]Modify batch send delay time to 3000ms in unit test. ShannonDing/rocketmq
2 participants
@imzs @ShannonDing