[ISSUE #8058] Support for upgrading metadata in json to rocksdb #8081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
changed the title
lizhimins
changed the title
RongtongJin
reviewed
May 6, 2024
There was a problem hiding this comment.
I wonder know why this command was deleted?
|
Suggest adding a feature switch to broker config |
lizhimins
reviewed
May 7, 2024
| @@ -370,6 +378,7 @@ private void supportAttributes(List<Attribute> supportAttributes) { | |||
| } | |||
|
|
|||
| private boolean notToBeExecuted() { | |||
| return MixAll.isMac(); | |||
| // return MixAll.isMac(); | |||
lizhimins
reviewed
May 7, 2024
| public class ConfigRocksDBStorage extends AbstractRocksDBStorage { | ||
|
|
||
| private static final byte[] KV_DATA_VERSION_COLUMN_FAMILY_NAME = "kvDataVersion".getBytes(StandardCharsets.UTF_8); | ||
| private static final byte[] KV_DATA_VERSION_KEY = "dataVersion".getBytes(StandardCharsets.UTF_8); | ||
| protected ColumnFamilyHandle kvDataVersionFamilyHandle; |
lizhimins
reviewed
May 9, 2024
| } finally { | ||
| iterator.close(); | ||
| } | ||
| this.flushOptions = new FlushOptions(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8058
Brief Description
How Did You Test This Change?