[ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig #8418
Conversation
add test case for AclConfig in commom module Fixes #8417 Brief Description add test case for AclConfig in commom module by using tongyi tools. How Did You Test This Change? run test case successfull.
TeFuirnever
changed the title
|
for soc in #8262 . |
| public class AclConfigTest { | ||
|
|
||
| /** | ||
| * Test to verify that getGlobalWhiteAddrs returns null when no addresses have been set. |
There was a problem hiding this comment.
Test classes do not require method comments.
There was a problem hiding this comment.
Is it to remove all method level comments?
There was a problem hiding this comment.
Yes, it's not necessary in test class.
There was a problem hiding this comment.
By the way, why does my check item show "7 workflows awaiting approval"
There was a problem hiding this comment.
Wait, it's first contribution, need the approval of the committer.
There was a problem hiding this comment.
Thank you very much, I've modified it
There was a problem hiding this comment.
Sorry to bother you again, is codecov-commenter triggered automatically or do you need to trigger it manually?
There was a problem hiding this comment.
ci automatically triggered.
Thank you very much
ShannonDing
added
the
soc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8418 +/- ##
=============================================
- Coverage 45.12% 45.09% -0.03%
- Complexity 10931 10933 +2
=============================================
Files 1274 1274
Lines 88970 88970
Branches 11434 11434
=============================================
- Hits 40144 40118 -26
- Misses 43826 43848 +22
- Partials 5000 5004 +4 ☔ View full report in Codecov by Sentry. |
Which Issue(s) This PR Fixes
[Enhancement] Add test cases for org.apache.rocketmq.common.AclConfig #8417
Fixes #8417
Brief Description
add some test cases for org.apache.rocketmq.common.AclConfig.
How Did You Test This Change?
run test case successfull.
