only initialize all the variables once to speed up test ConsumeMessageConcurrentlyServiceTest #8436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eConcurrentlyServiceTest
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8436 +/- ##
=============================================
- Coverage 45.54% 45.48% -0.06%
+ Complexity 11031 11020 -11
=============================================
Files 1274 1274
Lines 88997 88997
Branches 11440 11440
=============================================
- Hits 40532 40481 -51
- Misses 43427 43467 +40
- Partials 5038 5049 +11 ☔ View full report in Codecov by Sentry. |
RongtongJin
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
We are not fixing existing issues in this commit.
Brief Description
Changes proposed in this pull request:
We put all the initialization of the mocks and variables into the method body of @BeforeAll and @afterall. There are two tests in the test class ConsumeMessageConcurrentlyServiceTest. However, these two tests are not affecting each other.
The test runtime can jump from 2.771 s to 1.768 s after applying the changes when run on our machine.
How Did You Test This Change?
We just ran this test class in any order and it passes. We ran this test class 10 times and it also passes. We also ran all tests in client module 10 times, and there are no changes for the test results.