Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8454] Active brokers number should be initailized to 1 in broker heartbeat manager. #8453

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

ShannonDing
Copy link
Member

@ShannonDing ShannonDing commented Jul 26, 2024

Which Issue(s) This PR Fixes

Fixes #8454

Brief Description

active brokers number should be initailized to 1 in broker heartbeat manager.

How Did You Test This Change?

wait to add test cases for this two class.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.88%. Comparing base (304987d) to head (cd489fa).

Files Patch % Lines
.../impl/heartbeat/DefaultBrokerHeartbeatManager.java 0.00% 1 Missing ⚠️
...ler/impl/heartbeat/RaftBrokerHeartBeatManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8453      +/-   ##
=============================================
- Coverage      45.92%   45.88%   -0.04%     
+ Complexity     11104    11098       -6     
=============================================
  Files           1274     1274              
  Lines          89001    89001              
  Branches       11441    11441              
=============================================
- Hits           40875    40841      -34     
- Misses         43027    43063      +36     
+ Partials        5099     5097       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin changed the title [ISSUE #]active brokers number should be initailized to 1 in broker heartbeat manager. [ISSUE #8454] Active brokers number should be initailized to 1 in broker heartbeat manager. Jul 28, 2024
@RongtongJin RongtongJin merged commit cc484d5 into apache:develop Jul 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]Active brokers number should be initailized to 1 in broker heartbeat manager
3 participants