Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute #8477

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

TeFuirnever
Copy link
Contributor

Which Issue(s) This PR Fixes

[Enhancement] Add test cases for org.apache.rocketmq.common.attribute #8476

Fixes #8476

Brief Description

Add more test coverage for Add test cases for org.apache.rocketmq.common.attribute.

How Did You Test This Change?

run test case successfull.
image
image
image
image
image
image
image
image
image

TeFuirnever and others added 6 commits July 21, 2024 15:49
add test case for AclConfig in commom module
Fixes apache#8417

Brief Description
add test case for AclConfig in commom module by using tongyi tools.

How Did You Test This Change?
run test case successfull.
[ISSUE apache#8417]add some test cases for org.apache.rocketmq.common.AclConfig apache#8417
…elop

# Conflicts:
#	common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java
add test case for AclConfig in commom module
Fixes apache#8476

Brief Description
add test case for org.apache.rocketmq.common.attribute in commom module by using tongyi tools.

How Did You Test This Change?
run test case successfull.
add test case for AclConfig in commom module
Fixes apache#8476

Brief Description
add test case for org.apache.rocketmq.common.attribute in commom module by using tongyi tools.

How Did You Test This Change?
run test case successfull.
@TeFuirnever
Copy link
Contributor Author

for soc in #8262 .

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.02%. Comparing base (8fe3451) to head (7ac3993).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8477      +/-   ##
=============================================
- Coverage      46.04%   46.02%   -0.02%     
- Complexity     11147    11151       +4     
=============================================
  Files           1274     1274              
  Lines          89000    89000              
  Branches       11443    11443              
=============================================
- Hits           40979    40962      -17     
- Misses         42905    42914       +9     
- Partials        5116     5124       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

add test case for AclConfig in commom module
Fixes apache#8476

Brief Description
add test case for org.apache.rocketmq.common.attribute in commom module by using tongyi tools.

How Did You Test This Change?
run test case successfull.
@ShannonDing ShannonDing added the soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on label Aug 1, 2024
@TeFuirnever
Copy link
Contributor Author

Hello, is there something wrong with this test item(Build and Run Tests by Bazel / bazel-compile (ubuntu-latest) (pull_request))?
image

@TeFuirnever
Copy link
Contributor Author

I see a lot of people having this problem, what can be done to fix it?

@TheR1sing3un
Copy link
Member

I see a lot of people having this problem, what can be done to fix it?

This bazel-build check isn't 'required' for pr merging, but u can try to fix these flaky tests if you are interested in this question.

@TeFuirnever
Copy link
Contributor Author

I see a lot of people having this problem, what can be done to fix it?

This bazel-build check isn't 'required' for pr merging, but u can try to fix these flaky tests if you are interested in this question.

Got it, thanks a lot!!!

@ShannonDing
Copy link
Member

@TeFuirnever A reminder from the Tianchi platform: it‘s better to submit your results to the official website asap.

@TeFuirnever
Copy link
Contributor Author

@TeFuirnever A reminder from the Tianchi platform: it‘s better to submit your results to the official website asap.

Got it, thanks so much! It was a great event!

@TeFuirnever
Copy link
Contributor Author

Hello, how about merged the code, I'm going to move on to other UT tests.
@ShannonDing

@TeFuirnever TeFuirnever closed this Aug 4, 2024
@TeFuirnever TeFuirnever reopened this Aug 4, 2024
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit d94d075 into apache:develop Aug 5, 2024
16 of 19 checks passed
@TeFuirnever TeFuirnever deleted the add-tests-for-attribute branch August 5, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add test cases for org.apache.rocketmq.common.attribute
4 participants