Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8517] Fix client send UNREGISTER_CLIENT request twice may cause proxy NPE #8528

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8517

Brief Description

client send UNREGISTER_CLIENT request twice may cause proxy NPE
check channel is null before use it, if channel is null, log warn instead of NPE

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 46.86%. Comparing base (fa0cd49) to head (b3f7df8).

Files Patch % Lines
...proxy/remoting/activity/ClientManagerActivity.java 0.00% 16 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8528      +/-   ##
=============================================
- Coverage      46.95%   46.86%   -0.09%     
+ Complexity     11325    11296      -29     
=============================================
  Files           1275     1275              
  Lines          89061    89067       +6     
  Branches       11454    11456       +2     
=============================================
- Hits           41815    41739      -76     
- Misses         42081    42155      +74     
- Partials        5165     5173       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins changed the title [ISSUE #8517] client send UNREGISTER_CLIENT request twice may cause proxy NPE [ISSUE #8517] Fix client send UNREGISTER_CLIENT request twice may cause proxy NPE Aug 13, 2024
@lizhimins lizhimins merged commit 7f5bf5f into apache:develop Aug 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add more test coverage for PullAPIWrapper
4 participants