Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8584] fix missing brokerName in sendMessageBack request #8585

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Aug 27, 2024

Which Issue(s) This PR Fixes

Fixes #8584

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.19%. Comparing base (a1ea1eb) to head (60d7fc3).

Files Patch % Lines
...ocketmq/client/consumer/DefaultMQPullConsumer.java 0.00% 1 Missing ⚠️
...ocketmq/client/consumer/DefaultMQPushConsumer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8585      +/-   ##
=============================================
- Coverage      47.27%   47.19%   -0.08%     
+ Complexity     11467    11450      -17     
=============================================
  Files           1277     1277              
  Lines          89342    89342              
  Branches       11480    11480              
=============================================
- Hits           42234    42168      -66     
- Misses         41918    41970      +52     
- Partials        5190     5204      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhanhui lizhanhui merged commit 720c87e into apache:develop Aug 30, 2024
10 checks passed
lizhanhui pushed a commit to qianye1001/rocketmq that referenced this pull request Aug 30, 2024
…apache#8585)

* fix missing brokerName in sendMessageBack request

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] missing brokerName in sendMessageBack request
6 participants